Skip to content

gh-89867: string.Formatter auto numbering doc updates#129617

Merged
encukou merged 4 commits into
python:mainfrom
dg-pb:string_formatter_parse_doc_update
Apr 30, 2025
Merged

gh-89867: string.Formatter auto numbering doc updates#129617
encukou merged 4 commits into
python:mainfrom
dg-pb:string_formatter_parse_doc_update

Conversation

@dg-pb

@dg-pb dg-pb commented Feb 3, 2025

Copy link
Copy Markdown
Contributor

@dg-pb

dg-pb commented Apr 29, 2025

Copy link
Copy Markdown
Contributor Author

@ZeroIntensity any chance you could check this one?

@ZeroIntensity ZeroIntensity left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not enough of an expert here to review, but the English and markup look mostly fine to me (see my one comment). I think @picnixz is the right person to tag, but he's going to be out for a little while last I heard.

Comment thread Doc/library/string.rst
@dg-pb

dg-pb commented Apr 29, 2025

Copy link
Copy Markdown
Contributor Author

Thanks, english check is what I hoped for.

Regarding logic, maybe @encukou could have a look? This is just clarifying docs after #21767.

@encukou encukou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@encukou encukou merged commit a4b7128 into python:main Apr 30, 2025
@github-project-automation github-project-automation Bot moved this from Todo to Done in Docs PRs Apr 30, 2025
mth4saurabh pushed a commit to mth4saurabh/cpython that referenced this pull request Apr 30, 2025
@dg-pb dg-pb deleted the string_formatter_parse_doc_update branch April 30, 2025 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip news

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants